Repository navigation
Fixed: Check condition field names even when no delegator is passed - #2548
Open
mridulpathak wants to merge 1 commit into
Open
mridulpathak wants to merge 1 commit into
mridulpathak wants to merge 1 commit into
Conversation
mridulpathak
commented
Nov 4, 2026
mridulpathak
commented
Contributor
- EntityExpr.checkRhsType checks again that the field exists in the entity model, and only skips the type checks that need a delegator when none is passed.
- EntityJoinOperator now passes the delegator on when it renders a binary AND/OR condition, so the conditions nested in it get the full check.
- EntityExpr.checkRhsType now checks that the field exists in the entity model before it skips the type checks that need a delegator - EntityJoinOperator now passes the delegator on when it renders a binary AND/OR condition, so the nested conditions get the full check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.