Repository navigation
Conversation
…ounting (OFBIZ-12349, OFBIZ-12350) Thanks to Pierre Smits for reporting both issues, and for raising the same need earlier in OFBIZ-10897. Thanks also to Jacopo Cappellato and Michael Brohl for triaging these tickets. This builds on earlier work that made it a small change: Nicolas Malin added the AgreementItemAttribute services in OFBIZ-6857, and Rahul Singh added the AgreementAttribute services in OFBIZ-7868, based on Rishi Solanki's description and committed by Arun Patidar. The entities and services were already in place, but no screen used them yet. This adds an Attributes tab to the agreement and agreement item screens, following the layout of the existing Terms tab: an add form above an editable list with update and remove. The AgreementAttribute services were in the party component without a permission check. As they are now reachable from accounting, they move next to the AgreementItemAttribute services and use the same acctgAgreementPermissionCheck. The service names are unchanged, and there are no other callers in the codebase. Checked on a running instance with agreement 8000 and item 0001: attributes can be added, updated and removed at both levels, and a view-only user (auditor) can see the tabs but is refused when adding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: OFBIZ-12349, OFBIZ-12350
Thanks to Pierre Smits for reporting both issues, and for raising the same need
earlier in OFBIZ-10897. Thanks also
to Jacopo Cappellato and Michael Brohl for triaging these tickets.
Most of the groundwork was already done, which kept this change small:
Nicolas Malin added the AgreementItemAttribute services in
OFBIZ-6857, and Rahul Singh added
the AgreementAttribute services in OFBIZ-7868,
based on Rishi Solanki's description and committed by Arun Patidar.
What this does
The attribute entities and their services were in place, but no screen used them yet.
This adds an Attributes tab to the agreement screen and to the agreement item screen,
following the layout of the existing Terms tab: an add form above an editable list with
update and remove.
One small note
The AgreementAttribute services were in the party component without a permission check.
As they are now reachable from accounting, I moved them next to the AgreementItemAttribute
services and gave them the same
acctgAgreementPermissionCheck. The service names areunchanged, and I could not find other callers in the codebase. I hope this is the right
home for them, and I am happy to adjust if another approach is preferred.
How to test
8000.0001, and repeat on its Attributes tab.auditor(view-only), the tabs are visible but adding an attribute isrefused with a permission message.
I checked these steps on a running instance. Thank you for taking the time to review.