Repository navigation
refactor(@angular/build): remove oxc WASI shim - #34646
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the oxc-wasi-shim.ts file and its associated imports across several files, including the i18n inliner worker, OXC transform, and traversal tools. This shim was originally introduced as a workaround for upstream WebAssembly/WASI binding incompatibilities. There are no review comments to evaluate, so I have no feedback to provide.
alan-agius4
added
action: review
The upstream issue with @napi-rs/wasm-runtime and @emnapi/core WASI fallback resolution has been fixed in @napi-rs/wasm-runtime@1.2.7 (napi-rs/napi-rs#3680), making the temporary WASI shim no longer necessary.
alan-agius4
force-pushed
the
refactor/remove-oxc-wasi-shim
branch
from
November 3, 2026 17:50
2578c24 to
5affb76
Compare
dgp1130
approved these changes
Nov 3, 2026
alan-agius4
added
action: merge
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream issue with
@napi-rs/wasm-runtimeand@emnapi/coreWASI fallback resolution has been fixed in@napi-rs/wasm-runtime@1.2.7(napi-rs/napi-rs#3680), making the temporary WASI shim no longer necessary.