Skip to content

chore: upgrade Maven wrapper to 3.10.0 and use ./mvnw in workflows - #4408

Open
xuxiaowei-com-cn wants to merge 3 commits into
alibaba:2026.0.xfrom
xuxiaowei-com-cn:xuxiaowei/2026.0.x-maven-3.10.0
Open

xuxiaowei-com-cn wants to merge 3 commits into
alibaba:2026.0.xfrom
xuxiaowei-com-cn:xuxiaowei/2026.0.x-maven-3.10.0

Conversation

@xuxiaowei-com-cn

Copy link
Copy Markdown
Collaborator

Describe what this PR does / why we need it

Does this pull request fix one issue?

#4407

Describe how you did it

Describe how to verify it

Special notes for reviews

@xuxiaowei-com-cn xuxiaowei-com-cn linked an issue Oct 1, 2026 that may be closed by this pull request

@oss-sentinel-ai oss-sentinel-ai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Same change as #4410, targeting the 2026.0.x branch — Maven wrapper 3.9.14 → 3.10.0, removal of the unused maven-wrapper.jar (fine with distributionType=only-script), and mvn → ./mvnw in workflows.

The blocking issue identified in #4410 applies here as well: in .github/workflows/github-packages-release.yml, ./mvnw is invoked after cd $GITHUB_WORKSPACE/spring-cloud-alibaba-dependencies / .../spring-cloud-alibaba-starters, but the wrapper script only exists at the repository root, so those deploy steps will fail. Use "$GITHUB_WORKSPACE/mvnw" or run ./mvnw -f <module>/pom.xml ... from the root instead. See the detailed inline review on #4410.

Thanks for keeping the maintained branches in sync — please apply the same fix across all three PRs.


Automated review by github-manager-bot

Wrap each deploy command in a subshell so a cd into a submodule no
longer leaks into the following commands, and invoke the Maven wrapper
via its absolute path after changing directory.

@oss-sentinel-ai oss-sentinel-ai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

The follow-up commit 1260874 ("ci: isolate Maven deploy commands in subshells") applies the same fix verified on #4410: deploy commands run in isolated subshells and module-level deploys use the absolute path $GITHUB_WORKSPACE/mvnw, so the root-only wrapper resolves correctly after cd into the module directories.

CI (Integration Testing, deploy-docker-image) is green and the CLA is signed. LGTM — approving. 2026.0.x stays in sync with the other maintained branches.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maven upgrade to 3.10.0

2 participants