Repository navigation
value: check setn failure in json_object_update_existing/missing - #765
Open
hilbert149 wants to merge 1 commit into
Open
hilbert149 wants to merge 1 commit into
hilbert149 wants to merge 1 commit into
Conversation
json_object_update_existing() and json_object_update_missing() ignored the return value of json_object_setn_nocheck(), so they returned 0 (success) even when the set failed. The documentation states that they return 0 on success or -1 on error, and json_object_update() already propagates the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json_object_update_existing() and json_object_update_missing() ignored the return value of json_object_setn_nocheck(), so they returned 0 (success) even when the set failed. The documentation states that they return 0 on success or -1 on error, and json_object_update() already propagates the error.