Repository navigation
fix(text): account for fontSize when measuring text - #2034
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
Measure the effective font size for scaling and wrapping, update measurements on fontSize changes, and apply relative font sizes once instead of compounding them on the wrapper SVG. Fixes airbnb#1737
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Textmeasures words usingstylebut ignores thefontSizeprop, so scaling and wrapping use the wrong widths. Include the effective font size in measurement and memoization, preserve inline-style precedence, and clear a previous measurement size when the prop is removed. Apply relative font sizes only on the text element so values such as2emdo not compound on the wrapper SVG.Fixes #1737.
Validation: 23 text tests passed, including regressions that failed before the fix. Package typecheck, CJS/ESM builds, and changed-source lint passed. A real Chrome check covered seven size/override/rerender cases; rendered text matched a 100px target within 0.2px.