Repository navigation
fix(drag): resample when the restriction path changes - #2032
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
restrictToPathswitches to another SVG geometry with the same total length,useSamplesAlongPathreuses points from the previous element. Dragging remains constrained to the old path.Include the path element in the memo dependencies while retaining the length dependency. Add a regression for switching equal-length paths and a check that an unchanged path reuses its samples.
Validation: the replacement-path regression fails before the fix; all 8 tests across the 5 visx-drag test files pass afterward. Prettier passes for both changed files. Tests ran with Vitest/jsdom and the package configuration; the full monorepo build was not run.
Prepared with Codex assistance.