Repository navigation
Link check: don't let bash -e abort on lychee exit 2 - #535
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly link check (run 41398797258) failed with exit code 2 and left no report.
GitHub Actions runs
run:steps withbash -e, andset -uo pipefaildoesn't turn that off. So when lychee exited 2 (broken links found), the step stopped beforestatus=$?. The report was never added to the step summary, and the "Broken links report" issue step was skipped.This change captures lychee's exit code with
|| status=$?. When there are broken links, the job now passes and opens or updates the issue, as intended. Any other non-zero exit still fails the job.To check: a
workflow_dispatchrun on this branch should finish green and open or update the "Broken links report" issue with the current broken links.🤖 Generated with Claude Code