Repository navigation
Conversation
- Add ListSingles base class following ListTime/ListEvent pattern - Add is_singles()/singles() to CListRecord with default implementations - Decode PETLINK singles words in CListRecordECAT8_32bit (type=1, subtype=1) - Accumulate per-bucket singles in LmToProjData, write to JSON file - Add SinglesRatesFromJSON to read per-bucket singles rates - Read dtp/dtnp dead time parameters from ECAT8 norm binary file - Implement combined paralysable/non-paralysable dead time formula in BinNormalisationFromECAT8 using real per-frame singles rates - Store pre-computed alive fractions in PETSIRD DeadTimeTimeBlock entries during STIR2PETSIRD conversion (scanner-agnostic at reconstruction time) - Read DeadTimeTimeBlock entries in BinNormalisationFromPETSIRD with time-windowed selection for per-frame dead time correction - Release PETSIRD file reader after read_norm_data() to reduce memory usage - Add singles accumulation to CListModeDataPETSIRD for PETSIRD pipeline
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 70 |
| Duplication | 5 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
More accurate singles distribution, it is done properly per bucket now
Fixed the dead-time, turns out the scaling was incorrect
changed the file to resemble ECAT8 normalisation more
Updated with the new dead-time write to norm sino that works with per module singles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Testing performed
Performed full quantitative reconstruction on this: https://zenodo-rdm.web.cern.ch/records/4751233
It looks good, but ideally e7 tools can be used to compare the normalisation sinogram which I do not have access to at the moment.
Related issues
Checklist before requesting a review
Contribution Notes
Please tick the following: