Repository navigation
fix(trxf): preserve numeric operand grouping in feature evaluation - #213
Open
Hanabi9248 wants to merge 1 commit into
Open
Hanabi9248 wants to merge 1 commit into
Hanabi9248 wants to merge 1 commit into
Conversation
Parenthesize each serialized operand before evaluating a binary operation, so accepted Fraction values do not alter operator precedence. Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature.evaluate accepts numeric assignment operands, including fractions.Fraction, but serializes each binary operation without grouping the operands. For Feature('x/y') with x=Fraction(1, 2) and y=Fraction(1, 3), this builds 1/2/1/3 and returns 1/6 instead of 1.5. The wrong value also changes real Predicate decisions.
Parenthesize each serialized operand before the existing evaluation. This preserves operand order and the existing validation, categorical features, Decimal/constant compatibility and final float conversion. It does not change the unary grammar or claim exact rational arithmetic or complete arbitrary Number support.
Validation against master 0ce916f:
Run the added regression with: python tests/rule_induction/trxf/core/test_feature_numeric_operands.py -v
This is separate from #155's operand-pop order correction and #211's metrics changes. AI assistance was used to prepare and review the patch; the reported test results come from actual local runs.