Repository navigation
Vendor cyclist position fields (#611) alongside NewRoutes (#621) - #34
Merged
Merged
Conversation
Repoints the gtfs-spec submodule from the bare head of google/transit#621 to TransitApp/transit@vendored-with-proposals, which is upstream master plus a merge commit per proposal we adopt early: #611 cyclist positions VehiclePosition 12/13, CarriageDetails 6/7 #621 NewRoutes Route, FeedEntity.route, TripProperties.route_id Previously the pin could only carry one in-flight proposal at a time, since a submodule pin is a single commit and each PR head sits on its own base. Pinning an integration branch lifts that limit and also recovers the 15 master commits both heads were missing (Alert.communication_period, Alert.impact_period, Cause.SPECIAL_EVENT). The pin stays fetchable through the existing .gitmodules URL: GitHub serves any commit in a public fork network by SHA from the parent repo, which is the same mechanism that made the previous pin work. No .gitmodules change and no `git submodule sync` needed. Node bindings regenerated (CJS + ESM + both .d.ts); version 1.11.0. The diff against 1.10.0 is purely additive - no types removed. Refreshing the branch: reset it to upstream master and re-merge each still-open PR head. Never merge master into it - google/transit squash-merges, so a landed PR arrives as a new commit that git will not recognise as already applied. Deleting it: once #611 and #621 have both landed upstream, repin gtfs-spec to google/transit master and delete the branch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
gcamp
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning out the claude slop (see the commit msg if you are interested)
This points us to a new branch on our fork that has both the new route and cyclist position proposals.
It carries some unrelated Alerts changes that we haven't pulled through yet.
Once both PRs are merged, we can delete the
vendored-with-proposalsbranch and re-point towards master