Repository navigation
[NUI] Rebase main to DevelNUI - #7888
Merged
Merged
Conversation
… code BUILD_TCORE_ENABLE now selects the tcore code path at compile time and the new BUILD_EFL_DISABLE compiles out all EFL-dependent code so the assemblies can run on targets without EFL so's: BUILD_TCORE_ENABLE=1, BUILD_EFL_DISABLE=0 : tcore path, EFL interop kept BUILD_TCORE_ENABLE=1, BUILD_EFL_DISABLE=1 : tcore path, EFL code removed BUILD_TCORE_ENABLE=0, BUILD_EFL_DISABLE=0 : EFL path (unchanged default) BUILD_TCORE_ENABLE=0, BUILD_EFL_DISABLE=1 : build error (no backend) - csproj (Tizen.WindowSystem, Tizen.NUI.WindowSystem, BackendSmokeTest): map BUILD_EFL_DISABLE to DefineConstants and add a validation target that fails the build when no backend would be compiled in. - Interop.EcoreWl2.cs (both projects): wrapped in #if !BUILD_EFL_DISABLE so libecore_wl2.so.1 P/Invokes are compiled out when EFL is disabled. - TizenShell.cs (both projects): EFL fallback branches of the constructor, GetWindowId and (WindowSystem) GetWindowScreenSize changed from #else to #elif !BUILD_EFL_DISABLE so they vanish together with the EFL interop when the EFL backend is disabled. - EFL-independent #else branches kept as-is: NUI QuickPanelClient screen size fallback uses Tizen.System.Information, and the smoke test #else only changes result labels. All flag combinations except the no-backend error case must build. Co-Authored-By: Cline SR
Signed-off-by: Abhimanyu Swami <abhimanyu1.s@samsung.com>
* [Multimedia] Change ecore to tcore display
dongsug-song
requested review from
JoogabYun,
bshsqa,
hsgwon,
rabbitfor and
randeepsingh01
as code owners
November 16, 2026 05:30
Collaborator
Build Error: |
- Add global.json specifying .NET SDK 8.0 to prevent .slnx generation - Update dotnet-version to install both 3.1 (for APITool runtime) and 8.0 (for build) - Inject global.json into base branch checkout directory in check-api job
dongsug-song
force-pushed
the
rebase-main-1116-1
branch
from
November 16, 2026 11:45
642cd6a to
f27418c
Compare
Contributor
Author
|
just an integratoin. all patches are already got code reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[NUI] Rebase main to DevelNUI