Repository navigation
Conversation
eddyb
force-pushed
the
eddyb/structurize-noret
branch
from
October 9, 2026 16:29
ac75d66 to
00bc398
Compare
eddyb
force-pushed
the
eddyb/structurize-noret
branch
2 times, most recently
from
October 12, 2026 10:56
3e11d68 to
ddd8786
Compare
eddyb
force-pushed
the
eddyb/structurize-noret
branch
from
October 12, 2026 11:03
ddd8786 to
5729473
Compare
eddyb
force-pushed
the
eddyb/structurize-noret
branch
from
October 12, 2026 14:41
5729473 to
f8d388e
Compare
eddyb
force-pushed
the
eddyb/structurize-noret
branch
from
October 12, 2026 14:46
f8d388e to
84dab26
Compare
eddyb
added this pull request to stack #53
October 12, 2026 15:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR is a draft to avoid accidental merging onto its "base" branch (used as a form of ad-hoc PR stacking), and will remain as such, until its "base" branch can be set to
main, i.e. all prerequisite PRs will have landed, up to and including this PR (whose branch is the "base" of this one):ConstKind::Undef(i.e. SPIR-VOpUndef).聽#37This was a small oversight - if a function never returned, structurization didn't even have the necessary type(s) to create
undefconstant(s) to fill the function body's outputs, so it left such functions partially unstructured.The fix is mainly to pass the whole
FuncDeclin, not just theFuncDefBody, giving access to the signature.