Repository navigation
feat: Add async characteristic subscription that awaits BLE setup - #945
Merged
PieterAelse merged 1 commit intoOct 22, 2026
Merged
PieterAelse merged 1 commit into
PieterAelse merged 1 commit into
Conversation
The existing `subscribe()` method returns a stream immediately, potentially leading to race conditions or unhandled errors if the underlying BLE notification setup fails or is delayed. This new `subscribeAsync()` method waits for the BLE subscription on the native platform to be fully established before returning the stream, providing a more robust and predictable API.
PieterAelse
reviewed
Oct 16, 2026
PieterAelse
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
subscribe()method returns a stream immediately, potentially leading to race conditions or unhandled errors if the underlying BLE notification setup fails or is delayed. This newsubscribeAsync()method waits for the BLE subscription on the native platform to be fully established before returning the stream, providing a more robust and predictable API.