You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Desktop onboarding could incorrectly downgrade a previously-configured install to "needs setup" when runtime readiness probes returned only fallback errors (for example transient request timed out: setup.runtime_check / reconnect windows).
This showed up as random status flapping (connected -> needs setup -> offline) and could block composer usage even though credentials were already valid.
Root Cause
refreshOnboarding() treated non-ready fallback results as authoritative and immediately set configured=false.
Fallback results are intentionally non-authoritative (transport timeout/disconnect), so using them to downgrade state causes false negatives.
Fix
Preserve configured=true when readiness result is fallback-only and onboarding was not explicitly requested/manual.
Keep existing strict behavior for first-run/manual/requested onboarding flows.
Tests
Added regression coverage:
Previously configured desktop install is not downgraded on fallback timeout.
Unconfigured/requested onboarding still surfaces correctly on fallback failure.
Commits
fix(desktop): keep configured onboarding state on fallback runtime probes
Duplicate of #37634 — same fix for the same mechanism: refreshOnboarding() in apps/desktop/src/store/onboarding.ts treats non-authoritative fallback runtime-check results (transient timeouts) as authoritative and downgrades a configured install to "needs setup". #37634 (earlier open PR, fixes #37554) keeps the onboarding state sticky across the same transient failures.
Merged via PR #51884 — your shouldPreserveConfiguredOnFallback helper and initial tests were cherry-picked with authorship preserved. The salvage added a notify() call with a stable id for non-blocking dedup'd notifications, removed a dead !state.manual guard, and added two more negative-case tests.
Thanks for the clean, well-targeted fix! Your approach of gating on runtime.source === 'fallback' was the right call — it correctly distinguishes transient timeouts from authoritative "not configured" responses.
Also credited in the PR body: @mohamedorigami-jpg (PR #37634) who independently proposed the notification-on-preserve idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/desktopElectron desktop app (apps/desktop/*)duplicateThis issue or pull request already existsP3Low — cosmetic, nice to havetype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop onboarding could incorrectly downgrade a previously-configured install to "needs setup" when runtime readiness probes returned only fallback errors (for example transient
request timed out: setup.runtime_check/ reconnect windows).This showed up as random status flapping (connected -> needs setup -> offline) and could block composer usage even though credentials were already valid.
Root Cause
refreshOnboarding()treated non-ready fallback results as authoritative and immediately setconfigured=false.Fallback results are intentionally non-authoritative (transport timeout/disconnect), so using them to downgrade state causes false negatives.
Fix
configured=truewhen readiness result is fallback-only and onboarding was not explicitly requested/manual.Tests
Added regression coverage:
Commits