Repository navigation
Conversation
Author
|
Closing — not pursuing this batch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refresh of #125295 (closed stale) onto current
main.The
bundle-smoke-metadataPowerShell test shellspowershell.exe(Windows PowerShell 5.1), but its asset only preloads
System.IO.Compression.FileSystem. TheZipArchiveModeenum lives inSystem.IO.Compression, which 5.1 does not resolve implicitly (PowerShell 7does) — so every run dies before any assertion with
Unable to find type [IO.Compression.ZipArchiveMode]. One-line fix in the test asset; the moduleunder test uses XML types only and is untouched.
Evidence (Windows 11, Windows PowerShell 5.1.26100.9587)
main:TypeNotFound—InvalidOperation: (IO.Compression.ZipArchiveMode:TypeName)before any assertion runs.
PASS: MSIX identity/executable and MSIXBUNDLE native-slice admission.Related Issue
Fixes #125294
Type of Change
Changes Made
tests/install/e2e-assets/windows-bundle-metadata.test.ps1: preloadSystem.IO.CompressionbeforeSystem.IO.Compression.FileSystem(re-loading an already-loaded assembly is a no-op, so PS 7 behavior is
unchanged).
How to Test
powershell.exe -NoProfile -ExecutionPolicy Bypass -File tests/install/e2e-assets/windows-bundle-metadata.test.ps1node_modules/.bin/vitest run bundle-smoke-metadata.test.mjs -t "PowerShell admits only the pinned package"Before:
TypeNotFoundatwindows-bundle-metadata.test.ps1:11.After:
PASS: MSIX identity/executable and MSIXBUNDLE native-slice admissionstandalone,
1 passedin the harness.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass — N/A (JS/PS asset only; ran the asset standalone instead)Documentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A