Repository navigation
Conversation
Ripple Trellis writes 2.2 files with electrode IDs by front-end port (1-128, 129-256, 257-384...). Spike packets of a 2.2 file were recognized only for IDs 1-255, so every spike on a higher electrode matched no packet type and was dropped without a warning. The 2.2 range is now 1-2048, as for 2.3. Also document next to the table which packet IDs of 3.0 files written by Central are ignored on purpose (preview packets, recording events).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the dropped spikes in #1918: spike packets of a 2.2
.nevwere only recognized for IDs 1-255, so a Ripple Trellis recording with electrodes 257+ lost every spike. The 2.2 range is now(1, 2048), the same as 2.3.The test builds a 2.2 file from neo's 2.3 test file (spec byte changed, electrode 1 renumbered 300 in its
NEUEVWAVheader and spike packets) and checks that electrode 300's spikes equal electrode 1's in the original. It fails on the old range. I did not run the Trellis sample from the issue through this.This does not add the warning the issue also asks for when data packets match no known type. I also added a comment above
NEV_PACKET_IDENTIFIERS_BY_SPECthat lists the packet IDs of 3.0 files written by Central that are ignored on purpose, so a future warning does not need to treat them as surprises:0x8000 + channellive-protocol preview packets, and0xFFF9recording events (start/stop/pause/resume, per Central'sCNevFile30::AddRecordingEvent).@h-mayorquin you mentioned working on Blackrock this week: we are fine with whatever solution you come up with for #1918 (the range, the warning, or both). Feel free to close this in favor of yours, or push to this branch.