Repository navigation
Conversation
mdenker
added
bug
Collaborator
|
coverage: 88.527% (-0.08%) from 88.605% — mdenker:fix/cv2doc into NeuralEnsemble:master |
CozySocksAlways
approved these changes
Oct 7, 2026
Contributor
There was a problem hiding this comment.
Looks straight forward is non code change, so good to go.
Looking through the failing tests, I found are from unrelated issues:
- The known gin data download issue
- exact floating point match on macOS, probably have to use numpy.allclose instead in the respective tests
- omp library issue with deployment target on mac
Will open a separate PR to fix macOS issues.
Contributor
|
This will be superseded by #714 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a small fix to the doc strings to make them in line with the function definiton.