Repository navigation
Update to Rust edition 2024 / Bump MSRV to 1.88.0 - #69
Conversation
Signed-off-by: Nico Wagner <n.wagner@dnb.de>
|
It appears that GitHub Actions I could remove the What do you think about that, @juhoinkinen? |
I think some users are still to installing Omikuji as a sdist, and the Rust version requirement could affect them. But I don't know if that's a real problem. Can anyone update to Rust 1.99 on their machine easily without breaking some other projects they might be building? Actually, it seems to be possible to have multiple versions of rustc and cargo etc. using the toolchain thing (not a surprise, I think), so updating to and using Rust 1.99 should not be a big problem. However, does requiring version 1.99+ of Rust give benefits? Could the required version be some older one; the 1.99 is very recent (I have 1.97 on my laptop, and that too was released just this July)? What could be oldest sensible version that would work as MSRV? The matrix checking the Rust versions is good!
Yes, please avoid nextest; while it could be faster, the default rust-build job is not too slow currently.
The action
The old rust-build job could be removed in this PR directly. |
|
BTW, how you feel about AI reviews @nwagner84? I've been using the Copilot review lately, because it really can spot things I miss (especially with Rust...). |
Signed-off-by: Nico Wagner <n.wagner@dnb.de>
Signed-off-by: Nico Wagner <n.wagner@dnb.de>
|
Hi @juhoinkinen, good point; maybe setting the MSRV to I have no issue with a co-pilot review. |
There was a problem hiding this comment.
🟡 Changes recommended
CI does not validate the C API at the declared MSRV and has unresolved musl and release-gating issues.
2 open findings
What changed in this PR
Raises the Rust MSRV to 1.80.1 and adds stable/MSRV CI coverage across GNU and musl targets.
Changes:
- Declares the MSRV for both crates.
- Adds Rust toolchain and target test coverage.
- Adds documentation and example checks.
| File | Description |
|---|---|
Cargo.toml |
Declares the root crate’s MSRV. |
c-api/Cargo.toml |
Declares the C API crate’s MSRV. |
.github/workflows/cicd.yaml |
Adds Rust toolchain and target testing. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Nico Wagner <n.wagner@dnb.de>
Signed-off-by: Nico Wagner <n.wagner@dnb.de>
Signed-off-by: Nico Wagner <n.wagner@dnb.de>
Signed-off-by: Nico Wagner <n.wagner@dnb.de>
Signed-off-by: Nico Wagner <n.wagner@dnb.de>
Signed-off-by: Nico Wagner <n.wagner@dnb.de>
844eae9 to
458fea9
Compare
1.80.11.88.0
Signed-off-by: Nico Wagner <n.wagner@dnb.de>
c28f04d to
8b621ca
Compare
|
Hi @juhoinkinen, I've revised the PR a bit more and incorporated the review comments. I've also updated the PR description. As far as I'm concerned, the PR is now ready, and you can merge the change. As noted, I’ve kept the old |
At first I was inclined to having the linting ( |
juhoinkinen
left a comment
There was a problem hiding this comment.
Looks good. I think this can be merged.
As far as I can see, the changes on the Rust code are non-operational modernizations.


Summary
This PR update to the latest Rust edition 2024. As a result the minimum supported Rust version (MSRV) has to be updated to
1.88.0.Changes
Rust Edition
The Rust edition has been updated to version 2024 to enable the use of new language features in future developments. The resulting minor compiler errors have been fixed. The version of the
c-apicrate has been left at 2021, as updating it would require additional effort and the integration is anyway to be switched topyo3.Minimum Supported Rust Version (MSRV)
In addition, the MSRV was set to version
1.88.0. The MSRV was determined using the cargo-msrv tool:However, the MSRV was set to
1.88.0because thetimedependency requires at least this version:CI/CD-Pipeline
I've expanded the pipeline to include an additional build step,
rust-test, which tests both thestableversion (gnu/musl) and the explicit MSRV version1.88.0in a matrix. This makes it possible to determine at any time whether features are being used in development that aren't supported by the MSRV and require a version adjustment.Furthermore, I've switched to the GitHub Action dtolnay/rust-toolchain, which is widely used in the Rust community to incorporate different Rust versions into CI/CD pipelines.
Documentation tests are also being run, even though there aren't any. I think it makes sense to run them at the same time to ensure that future tests in the documentation are taken into account.
Note, that the new pipeline step
rust-testcontains redundancies withrust-build, which I would remove in a follow-up PR.