Repository navigation
Use committed version metadata in release builds for reproducible APKs - #310
Merged
Merged
Conversation
Computing VERSION_CODE from github.run_number and passing it via -PversionCode in CI caused the release APK's AndroidManifest.xml and BuildConfig.VERSION_CODE to diverge from what IzzyOnDroid builds from the git tag (#309). Sync app-versionCode and CURRENT_PROJECT_VERSION to 108 (matching the published v8.0.0 store builds), update /prepare-release to bump the committed version metadata before every beta and production release, and have release.yml validate and build directly from gradle/libs.versions.toml without CLI overrides or workspace changelog mutations.
github-actions
Bot
added
chore
IzzyOnDroid's Debian yq parser cannot evaluate dashed keys like .versions.app-versionCode in gradle/libs.versions.toml (#309). Using underscores (app_versionCode and app_versionName) allows yq to read them directly while generating the same libs.versions.app.versionCode Kotlin accessors in Gradle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computing
VERSION_CODEdynamically fromgithub.run_numberand injecting it via-PversionCodein CI caused the signed GitHub Release APK'sAndroidManifest.xmlandBuildConfig.VERSION_CODEto diverge from a clean build of the git tag, breaking IzzyOnDroid Reproducible Builds forv8.0.0.Since
/prepare-releasealready runs before every beta and production deployment, bumpingapp_versionCodeandapp_versionNameingradle/libs.versions.toml(renamed fromapp-version*to use underscores for compatibility with IzzyOnDroid'syqparser, along withMARKETING_VERSIONandCURRENT_PROJECT_VERSIONinproject.pbxproj) as part of the release-prep PR keepsgradle/libs.versions.tomlas the single source of truth.release.ymlnow verifies that the release tag matches the committed version metadata and runs:app:assembleReleasewithout CLI property overrides or workspace changelog mutations so external builders produce byte-for-byte identical APKs.Fixes #309