Repository navigation
fix(ci): harden SDK mirror workflow inputs - #259
Merged
Merged
Conversation
MaxRev-Dev
commented
Oct 31, 2026
MaxRev-Dev
left a comment
MaxRev-Dev
left a comment
Owner
Author
There was a problem hiding this comment.
Scope: .github/workflows/mirror-gisinternals-sdk.yml and win/partials.psm1. Independent local review and correction re-review completed against this head.
Findings: one P2 was resolved in the workflow checksum and release asset commands by prefixing file operands with ./, allowing leading-hyphen filenames safely. No remaining findings. Inputs use environment variables, filename and URL validation runs before download, and the SHA256 placeholder is unchanged.
Validation: actionlint and git diff --check passed; seven shell validation cases passed. HTTP and HTTPS Node HEAD requests returned 200 with matching ETag and content length. Ready for merge subject to required checks; CI was not watched.
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass mirror workflow inputs through environment variables and validate the zip filename and URL before downloading. Use HTTPS for the Windows SDK fallback; keep the SHA256 placeholder unchanged.
Verification:
actionlintandgit diff --checkpassed. Seven shell validation cases passed. Node HEAD requests to the HTTP and HTTPS SDK path both returned 200 with matching ETag and content length.