Skip to content

Cleanup eip712 message review callbacks - #1100

Merged
cedelavergne-ledger merged 1 commit into
developfrom
cev/small_refacto
Aug 17, 2026
Merged

cedelavergne-ledger merged 1 commit into
developfrom
cev/small_refacto

Conversation

@cedelavergne-ledger

Copy link
Copy Markdown
Contributor

No description provided.

@cedelavergne-ledger
cedelavergne-ledger requested a review from a team as a code owner August 17, 2026 08:34
@github-code-quality

Copy link
Copy Markdown

Code Coverage Overview

Languages: C

C / code-coverage/unittests

The overall coverage in commit e3f37fa in the cev/small_refacto branch is 93%. Coverage data for the develop branch is not yet available.

Show a code coverage summary of the most covered files.
File develop cev/small_refacto e3f37fa +/-
src/uint256.c — 100% —
src/plugins/eth...lugin_handler.c — 96% —
src/features/ge...ser/gtp_field.c — 95% —
src/features/si...x/eth_ustream.c — 94% —
src/features/ge...gtp_param_raw.c — 94% —
src/features/pr.../trusted_name.c — 90% —
src/features/pr...md_get_gating.c — 89% —
src/features/ge...gtp_data_path.c — 89% —
src/features/pr...tx_simulation.c — 89% —
src/features/si...logic_sign_tx.c — 83% —

@github-actions

github-actions Bot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

elf sizes
source = source branch cev/small_refacto
target = target branch develop

Device .text source .text target .text delta .bss source .bss target .bss delta max stack size source max stack size target max stack size delta
flex 191821 191821 0 23268 23268 0 13588 13588 0
nanos2 125539 125539 0 21964 21964 0 18988 18988 0
nanox 125283 125283 0 21980 21980 0 8192 8192 0
apex_p 171161 171161 0 23268 23268 0 17684 17684 0
stax 191742 191742 0 23268 23268 0 13588 13588 0

Stack consumption summary (clone_app_stack_consumption)

⚠️ This summary is for informative purpose only. It may not give the application actual worst case, for example if the test coverage is low.

Device Worst case (bytes) Remaining stack (bytes) Test
apex_p 2833 37747 test_clone.py::test_clone_thundercore_tx[apex_p]
flex 2881 33603 test_clone.py::test_clone_thundercore_tx[flex]
nanosp 2705 38063 test_clone.py::test_clone_thundercore_tx[nanosp]
nanox 2697 25783 test_clone.py::test_clone_thundercore_tx[nanox]
stax 2881 33603 test_clone.py::test_clone_thundercore_tx[stax]

Full details

Stack consumption summary

⚠️ This summary is for informative purpose only. It may not give the application actual worst case, for example if the test coverage is low.

Device Worst case (bytes) Remaining stack (bytes) Test
apex_p 5821 11863 test_gcs_formatters.py::test_gcs_group_sequential[apex_p]
flex 5821 7767 test_gcs_formatters.py::test_gcs_group_sequential[flex]
nanosp 5829 13159 test_gcs_formatters.py::test_gcs_group_sequential[nanosp]
nanox 5833 851 test_gcs_formatters.py::test_gcs_group_sequential[nanox]
stax 5821 7767 test_gcs_formatters.py::test_gcs_group_sequential[stax]

Full details

@github-actions

Copy link
Copy Markdown
Contributor

Code coverage report

Code Coverage

Per-file coverage
Package Line Rate Branch Rate Health
src 99% 98% ✔
src.features.generic_tx_parser 93% 81% ✔
src.features.get_app_configuration 100% 100% ✔
src.features.get_challenge 100% 100% ✔
src.features.get_eth2_public_key 98% 93% ✔
src.features.get_public_key 98% 97% ✔
src.features.perform_privacy_operation 98% 86% ✔
src.features.provide_enum_value 96% 87% ✔
src.features.provide_erc20_token_information 94% 88% ✔
src.features.provide_gating 89% 82% ✔
src.features.provide_map_entry 93% 76% ✔
src.features.provide_network_info 90% 81% ✔
src.features.provide_nft_information 91% 80% ✔
src.features.provide_proxy_info 97% 89% ✔
src.features.provide_safe_account 95% 88% ✔
src.features.provide_trusted_name 90% 82% ✔
src.features.provide_tx_simulation 89% 85% ✔
src.features.set_eth2_withdrawal_index 100% 100% ✔
src.features.set_external_plugin 89% 80% ✔
src.features.set_plugin 95% 90% ✔
src.features.sign_authorization_eip7702 87% 80% ✔
src.features.sign_message 88% 75% ✔
src.features.sign_tx 89% 79% ✔
src.nbgl 98% 87% ✔
src.plugins.eip7002 95% 87% ✔
src.plugins.eip7251 97% 87% ✔
src.plugins.erc1155 91% 81% ✔
src.plugins.erc20 91% 86% ✔
src.plugins.erc721 94% 86% ✔
src.plugins.eth2 94% 90% ✔
src.plugins 96% 90% ✔
src.plugins.swap_with_calldata 98% 94% ✔
src.swap 96% 93% ✔
src.utils 93% 90% ✔
Summary 93% (6916 / 7458) 84% (3386 / 4039) ✔

@codecov-commenter

codecov-commenter commented Aug 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.64%. Comparing base (9438102) to head (e3f37fa).

Files with missing lines Patch % Lines
src/nbgl/ui_sign_712.c 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1100      +/-   ##
===========================================
- Coverage    74.65%   74.64%   -0.01%     
===========================================
  Files          162      161       -1     
  Lines        14659    14653       -6     
  Branches      3529     3529              
===========================================
- Hits         10943    10938       -5     
+ Misses        3474     3473       -1     
  Partials       242      242              
Flag Coverage Δ
functionaltests 81.51% <100.00%> (-0.01%) ⬇️
fuzzing 43.01% <70.00%> (-0.01%) ⬇️
unittests 86.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cedelavergne-ledger
cedelavergne-ledger merged commit dffeddf into develop Aug 17, 2026
322 checks passed
@cedelavergne-ledger
cedelavergne-ledger deleted the cev/small_refacto branch August 17, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants