Repository navigation
[TwoFluidExample] Fix frozen free surface in two_fluid_wave - #161
Merged
Merged
Conversation
NickNick9
requested review from
loumalouomega
and
a balanced review from Copilot
October 21, 2026 08:33
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Member
|
Well, it is not new, I just pushed a fix of the scripts that were old and weren't working. |
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @loumalouomega , I’m new to two-fluid simulations and tried the two_fluid_wave example. The water surface stayed frozen, but adding "eulerian_fm_ale": false made the wave move. It seems the default setting makes VELOCITY − MESH_VELOCITY zero. Could this be a bug, or am I missing something? Could you confirm whether this change is appropriate?