Repository navigation
vtkOBJWriter fixes - #3755
Open
daker wants to merge 3 commits into
Open
vtkOBJWriter fixes#3755daker wants to merge 3 commits into
daker wants to merge 3 commits into
Conversation
The writer added //vn after /vt. Thus a face corner with texture coordinates and normals was v/vt//vn. The OBJ format is v/vt/vn. The writer now writes v/vt/vn. The PLY to OBJ test expected the incorrect syntax, and it now expects v/vt/vn. Fixes Kitware#3714
The writer did not write a texture coordinate when u was -1. But the faces always use texture coordinate i + 1 for point i. Thus after the first skipped value, all the subsequent faces referred to an incorrect texture coordinate, or to a texture coordinate that did not exist. The writer now writes all the texture coordinates. The face indices stay aligned with the points. Fixes Kitware#3715
The writer gave the vtkPoints object to decomposeStrip. decomposeStrip expects an array of point ids. Thus it logged an error, and the writer never wrote a strip. The writer now reads the point ids of each strip from the strip array, and gives them to decomposeStrip. The triangles keep the strip orientation. Fixes Kitware#3716
finetjul
approved these changes
Nov 13, 2026
finetjul
left a comment
finetjul
left a comment
Member
There was a problem hiding this comment.
LGTM.
It seems that some issues (e.g. -1 in uv generates some shift) are still in VTK. How easy would it be to automatically report/fix those in VTK C++ as well ?
Collaborator
Author
|
I will try to reproduce them with VTK C++ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #3714
Fixes #3715
Fixes #3716
Results
Changes
PR Checklist