Repository navigation
vtkPLYWriter fixes - #3753
Open
daker wants to merge 6 commits into
Open
vtkPLYWriter fixes#3753daker wants to merge 6 commits into
daker wants to merge 6 commits into
Conversation
The writer added the generated comment and the TextureFile comment to the headerComments option at each write. Thus each write added one more comment to the option and to the file. The writer now makes a new comment list for each write. The headerComments option stays the same. Fixes Kitware#3719
The writer replaced the withUVs and withColors values with a test for the data. Thus a false value had no effect. The writer now writes the texture coordinates and the colors only when the option is true and the data has the attribute. Fixes Kitware#3720
The withNormals option is true by default, and the writer did not compare it with the data. Thus the header declared nx, ny and nz, but the vertex records did not have normals. A reader then read all the vertices incorrectly, in the ASCII and the binary formats. The writer now declares and writes the normals only when the option is true and the polydata has normals. Fixes Kitware#3718
The writer read all point scalars as 3 component 8 bit colors. Thus RGBA colors got incorrect values, and float scalars became uchar values. The writer now writes colors only for 8 bit scalars with 3 or more components. It reads each tuple with the number of components of the array. Fixes Kitware#3722
The writer accepted the transform option, but it wrote the points without the transform. The writer now applies the transform matrix to each point. Fixes Kitware#3721
The writer read the cell array in steps of 4 and wrote 3 point ids for each face. The binary face size also used 3 ids. Thus quads and larger polygons lost points, and all the subsequent faces were incorrect. The writer now reads the point count of each cell, and writes all the point ids of the cell. The binary face size uses the length of the cell array. Fixes Kitware#3717
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #3717
Fixes #3718
Fixes #3719
Fixes #3720
Fixes #3721
Fixes #3722
Results
Changes
PR Checklist