Repository navigation
Drop the request timeout from the header ownership test - #1490
Merged
Merged
Conversation
The first request of this testset is the first network request in the suite, so it also pays for compiling the client and server. On macOS CI runners the testset takes 17-31 s, and the 20 s request_timeout failed a run (#1469) with TimeoutError after 22 s. test/README.md leaves deadlock detection to the job timeout instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
+ Coverage 91.12% 91.59% +0.47%
==========================================
Files 31 31
Lines 12535 13092 +557
==========================================
+ Hits 11422 11992 +570
+ Misses 1113 1100 -13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Header ownership and replay through HTTP/1 and HTTP/2testset passesrequest_timeout = 20to its firstHTTP.put. That is the first network request in the suite, so it also pays for compiling the client and server. On macOS runners the whole testset takes 17-31 s (#1467: 17.1 s, #1475: 25.3 s, #1473: 31.1 s), and #1469's macOS job failed withTimeoutErrorafter 22 s on that first request. Nothing there was wrong, just slow.test/README.mdsays product timeouts must not act as the test harness, and that the job timeout is the final guard for a real deadlock. So the keyword goes.Test-only, no CHANGELOG entry.
🤖 Generated with Claude Code