Repository navigation
Fix StaticArrays-backed polygons in clipping passthroughs - #532
Open
asinghvi17 wants to merge 1 commit into
Open
asinghvi17 wants to merge 1 commit into
asinghvi17 wants to merge 1 commit into
Conversation
Harness: codex Model: gpt-6.1-sol
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clipping and containment on StaticArrays-backed polygons have thrown a MethodError since #486.
_fh_as_ringand_fh_as_polybuilt their lists with comprehensions, which give aSizedVectorfor static input, while the tracer's polygon type expectsVectorstorage. This allocatesVectors explicitly instead, and adds tests for intersection, union, difference and cut on SVector polygons on both manifolds. Found while chasing the ConservativeRegridding downstream failure. The one red OverlayNG locator test on main is unrelated; #530 fixes it.🤖 Generated with Claude Code