Repository navigation
[paper] P9 minor revision: Reviewer B Round 4 fixes - #318
Merged
Merged
Conversation
…reservation, table fixes Reviewer B Round 4 minor revision — all 6 issues addressed: Fix 1: Remove unsupported epsilon>0.2 threshold. Replace with honest statement that artefactual intercept dominates for epsilon<0.5 and the clean asymptotic regime is the canonical operating range (epsilon~0.75). Fix 2: Clarify that N refers to Legendre-polynomial trial functions in the displacement expansion (N=3,5,7 for sensitivity; N=5 for main results). Fix 3: State explicitly that prolate geometries use parameter continuation within the oblate spheroidal coordinate Ritz formulation, not a switch to prolate spheroidal coordinates. Fix 4: Add symmetry-preservation honesty: the Ritz basis does not preserve exact a<->c exchange symmetry; sigma_3(0)=0 must be inferred from the continuous model. Fix 5: Remove misleading 'conservative' claim. Replace with direct statement that canonical oblate condition numbers are computed directly and unaffected by the near-sphere artefact. Fix 6: Add epsilon and c/a definitions to Table 1 caption. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JonathanMace
force-pushed
the
p9-minor-rev
branch
from
March 31, 2026 18:28
2e1ed95 to
ee73e5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 6 Reviewer B Round 4 minor revision issues addressed:
Tests: 487/487 pass. Paper compiles clean (6 pages).