Repository navigation
Conversation
staylorjlab
requested changes
Oct 29, 2026
staylorjlab
left a comment
staylorjlab
left a comment
Contributor
There was a problem hiding this comment.
It does not look like you restored the code that computes the minimum drift time for the forward tracks.
|
Test status for this pull request: SUCCESS Summary: summary.txt Build log: make_nsj_t0.log |
Contributor
Author
|
I will check. |
Contributor
Author
|
I restored that section too, will post new plots. |
Contributor
Author
|
|
Test status for this pull request: SUCCESS Summary: summary.txt Build log: make_nsj_t0.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I restored some of the code that Simon had removed and the issues with the CDC time residuals moving by 10um when ignoring the SC in track-fitting seem to be fixed.
CDC time to residuals plots follow.
This is using version set 7.8.0.
Left: normal tracking
Right: ignoring the SC, using -PUSE_SC_TIME=0
Same thing with this PR, fewer events
One might wonder why I would ignore the SC. It is to set the CDC base time offset so that the mean residuals do not change whether the SC is used or not. It could never be used for tracks that passing through the central gap in the nose.