Skip to content

Check for consistency in source grouping #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takluyver merged 5 commits into from
Nov 5, 2026
Merged

Check for consistency in source grouping #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0922446
Check for type consistency in source grouping.
Nov 4, 2026
41729f3
Corrected logic.
Nov 4, 2026
ec3a3d0
Added tests.
Nov 4, 2026
fadc67f
SourceGroup: check that same part varies from 3rd element instead of 4th
takluyver Nov 4, 2026
170bb5c
Comment to explain test case
takluyver Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extra_data/display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def add(self, name):
if len(diffs_at) != 1 or ((diff_at := diffs_at[0]) % 2 == 0):
return False # >1 part changed, or separator part changed

if len(grp) > 2 and (grp[-1][diff_at] == grp[0][diff_at]):
if len(grp) >= 2 and (grp[-1][diff_at] == grp[0][diff_at]):
return False # different part changing from current group

self.entries.append(split)
Expand Down
6 changes: 6 additions & 0 deletions extra_data/tests/test_display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ def test_group_ok(names, exp):
"SA1_XTD2_XGM/DOOCS/MAIN:output",
"SPB_XTD9_XGM/DOOCS/MAIN:output",
],
[
# One part changing each time, but different parts
'SQS_ILH_LAS/PROC/BS_CAM_800_OU1',
'SQS_ILH_LAS/PROC/BS_CAM_800_OU2',
'SQS_ILH_LAS/PROC/BS_CAM_TT_OU2',
],
])
def test_group_fail(names):
grp = SourceGroup()
Expand Down
Loading