Repository navigation
Conversation
| return f"<UnfurledMediaItem url={self.url} content_type={self.content_type}>" | ||
|
|
||
|
|
||
| class UnfurledScanMetadata: |
There was a problem hiding this comment.
Not really a fan of this naming, but then again, UnfurledMediaItemContentScanMetadata would be... a lot :>
While the API docs group this object under the unfurled media item stuff (which makes sense), in the API spec it is simply ContentScanMetadata. Maybe we could adopt that as well?
There was a problem hiding this comment.
With ContentScanMetadata we lose scope, these flags are meaningful only inside UnfurledMediaItem(s) we at least need Unfurled somewhere in the name IMO, e.g: UnfurledContentScanMetadata or UnfurledItemContentScanMetadata
There was a problem hiding this comment.
these flags are meaningful only inside
UnfurledMediaItem(s)
For now, yes, but this could potentially change in the future, we just kinda don't know :/
You're right, though, I suppose ContentScanMetadata is a lil unspecific. Maybe UnfurledMediaScanMetadata/UnfurledMediaScanFlags, then?
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Summary
Checklist
uv run nox -s lintuv run nox -s pyright