Skip to content

feat(flags): implement content scan flags - #1629

Open
Snipy7374 wants to merge 6 commits into
DisnakeDev:masterfrom
Snipy7374:feat/content_scan_flags
Open

Snipy7374 wants to merge 6 commits into
DisnakeDev:masterfrom
Snipy7374:feat/content_scan_flags

Conversation

@Snipy7374

Copy link
Copy Markdown
Collaborator

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running uv run nox -s lint
    • I have type-checked the code by running uv run nox -s pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Snipy7374
Snipy7374 requested review from Enegg and shiftinv November 5, 2026 21:46
@Snipy7374 Snipy7374 added t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Nov 5, 2026
@Snipy7374 Snipy7374 added this to the v2.13 milestone Nov 5, 2026
@read-the-docs-community

read-the-docs-community Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 disnake | 🛠️ Build #35844828 | 📁 Comparing 7810653 against latest (def5844)

  🔍 Preview build  

4 files changed
± genindex.html
± whats_new.html
± api/components.html
± api/messages.html

Comment thread changelog/1628.feature.rst Resolved
Comment thread disnake/components.py
return f"<UnfurledMediaItem url={self.url} content_type={self.content_type}>"


class UnfurledScanMetadata:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a fan of this naming, but then again, UnfurledMediaItemContentScanMetadata would be... a lot :>
While the API docs group this object under the unfurled media item stuff (which makes sense), in the API spec it is simply ContentScanMetadata. Maybe we could adopt that as well?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With ContentScanMetadata we lose scope, these flags are meaningful only inside UnfurledMediaItem(s) we at least need Unfurled somewhere in the name IMO, e.g: UnfurledContentScanMetadata or UnfurledItemContentScanMetadata

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these flags are meaningful only inside UnfurledMediaItem(s)

For now, yes, but this could potentially change in the future, we just kinda don't know :/
You're right, though, I suppose ContentScanMetadata is a lil unspecific. Maybe UnfurledMediaScanMetadata/UnfurledMediaScanFlags, then?

Comment thread disnake/flags.py Resolved
Comment thread disnake/flags.py Resolved
Comment thread disnake/flags.py Resolved
Comment thread disnake/flags.py Resolved
Snipy7374 and others added 3 commits November 12, 2026 17:35
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement new content scan flags

2 participants