Repository navigation
Conversation
Per-flag project statuses came from the flag_management default rules (#84). On a PR, the full flag is carried forward from the nightly base and projected onto the PR head, so the first PR that adds coverable lines (#93, +60) degraded the projected full coverage past the 0.5% threshold and failed codecov/project/projectfull -- a structural false positive: db-marked coverage only refreshes in the nightly run, so no PR can ever defend it. #90-#92 passed only because they were docs-only. Split the default rules into explicit per-flag rules: core keeps the enforcing project status (PRs upload it), full goes informational (nightly monitoring signal, visible on codecov.io and in the nightly report, but never gates a PR).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
==========================================
- Coverage 93.49% 93.47% -0.03%
==========================================
Files 138 138
Lines 18628 18628
==========================================
- Hits 17416 17412 -4
- Misses 1212 1216 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
PR #93 tripped
codecov/project/projectfullalthough its tests are green and core-flag coverage went up. Cause: on a PR thefullflag is carried forward from the nightly base and projected onto the PR head, so the first PR adding coverable lines (+60 in #93) degrades the projection past the 0.5% threshold. db-marked coverage only refreshes nightly, so no PR can defend it -- a structural false positive (#90-#92 passed only because they were docs-only).Split the flag_management default rules into explicit per-flag rules:
corekeeps the enforcing project status (what PRs actually upload),fullbecomes informational -- still a drift signal for the nightly runs, no longer a PR gate.After merge, #93's failed status clears on its next codecov evaluation.