Repository navigation
Wood box art: draw black inside covers, and redraw the calendar when a cover goes away - #2701
Merged
RocketRobz merged 1 commit intoOct 27, 2026
Conversation
Pure black was skipped everywhere in a cover, so on a light [box art] panel every black outline and the black DS-case spine showed the panel colour. Only the trailing black columns (DSpico covers' padding) are skipped now. When a cover goes away, the clock, year, month, day number and weekday are redrawn along with the day grid, so calendar pieces a theme put inside the [box art] panel come back.
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
This is a follow-up fix for #2698, which added box art to the Wood theme. It fixes two things in that change's
updateBoxArt():[box art]panel that showed the panel colour through every black outline and the black DS-case spine. Now only the trailing black columns (the padding, already left out of the centering) are skipped, and black inside the art is drawn. A dark panel looks the same as before.[box art]panel stayed blank until it next changed (the known limit noted in Wood: show box art in a theme-defined top-screen panel #2698). All of them are redrawn now.Changes are limited to
romsel_aktheme/arm9/source/graphics/graphics.cpp(+13/−2). Themes without[box art]are unchanged.Where have you tested it?
New Nintendo 3DS XL with a DSpico, TWiLight on the console SD, covers from
fat:/_pico/coverson the DSpico:[box art]panel, covers now show their black outlines and the black DS-case spine; with a near-black panel they look as before (tested in my own build, v27.25.1 + Wood: show box art in a theme-defined top-screen panel #2698 + this change + my other Wood changes);Before and after, Kirby Super Star Ultra on the white panel:
Pull Request status
Built in the
devkitpro/devkitarm:20241104Docker image that the nightly workflow uses.The code was written with help from an AI assistant (Claude Code). I reviewed it and tested it on my console.