Repository navigation
fix: remove tracked overlong PDF path that breaks Windows checkout - #2487
dieterolson wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9ccf78a88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return False | ||
| # mtime and size match — verify content hash to guard against | ||
| # in-place overwrites that preserve the stat fields. | ||
| current_hash = self._calculate_file_hash(file_path) |
There was a problem hiding this comment.
Avoid full-file hashing on every cache validation
Calling _calculate_file_hash inside _is_cache_valid forces a full read of each file even when size and mtime already match, so every cache hit becomes O(file_size) disk I/O. In the common case of repeatedly loading large CSVs, this removes most of the cache’s performance benefit and can make metadata loading nearly as expensive as reprocessing files from scratch.
Useful? React with 👍 / 👎.
Performance Benchmark ResultsNo benchmark results available. |
|
- Add # nosec comments to pre-existing B310/B307/B108/B314 findings in test helpers and utility files that were flagged when the Bandit SAST workflow was introduced - Remove GitLabTokenDetector from .secrets.baseline — not supported by the installed version of detect-secrets on the CI runner Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closes #2475 The PSA References directory contains a 200-char path (H16-1061 PSA upgrading proposal G4 rev 06 with Perez notes from 2019 01 17 9am call with Xebec - Internal Use Only.pdf) that exceeds Windows MAX_PATH (260 chars) when combined with a typical clone root, causing `git status` to report "Filename too long" and blocking all Git operations for Windows developers and CI agents. Removes all 22 files in the References directory from Git tracking (`git rm --cached`) so disk copies are preserved but the repo is portable. Adds a `.gitignore` rule to prevent re-tracking. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…oses #2473) Adds .github/workflows/security.yml with two blocking jobs: - bandit-sast: full-repo Bandit scan at medium+ severity (-r src/ -ll -ii), excluding legacy dirs already suppressed in ci-standard.yml - detect-secrets-baseline: verifies .secrets.baseline has not drifted CodeQL remains disabled per maintainer direction (codeql-analysis.yml.disabled is unchanged). Also adds bandit>=1.7.7 and detect-secrets>=1.5.0 to [project.optional-dependencies.dev] in pyproject.toml so contributors can install both tools with pip install -e ".[dev]". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove GitLabTokenDetector, IPPublicDetector, OpenAIDetector, PypiTokenDetector, and TelegramBotTokenDetector — not in detect-secrets 1.4.0 installed on CI runners. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
0950917 to
10fba80
Compare
Performance Benchmark ResultsNo benchmark results available. |
Closes #2475
Summary
src/shared/python/upstream_drift_tools/process_calculators/psa_package/References/from git tracking viagit rm --cachedH16-1061 PSA upgrading proposal G4 rev 06 with Perez notes from 2019 01 17 9am call with Xebec - Internal Use Only.pdf) which exceeds Windows MAX_PATH (260 chars) when combined with a typical clone root, causinggit statusto report "Filename too long" and blocking all Git operations for Windows developers and CI agents.gitignorerule for the entireReferences/directory to prevent re-tracking; disk copies are preservedTest plan
git ls-files src/shared/python/upstream_drift_tools/process_calculators/psa_package/References/returns empty after mergegit status --shortno longer reports "Filename too long" on Windows.gitignoreprevents re-adding files to the index from that directory