Repository navigation
Fix precedence of overlapping file content filters - #243
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The README and
AddFileContentFilterhelper document that the most recently registered matching pattern takes precedence.AconfCompileSysteminstead iterates the keys of an associative array, so overlapping filters are selected in hash order rather than configuration order.For example, registering a timestamp-removal filter for
/etc/second/connectionfollowed by an identity filter for/etc/second/*should preserve the timestamp for that file. On the current base, the earlier filter wins instead, andaconfmgr saveemits an unexpectedCopyFileoverriding the configured contents. Re-registering a pattern after another matching pattern also does not reliably give it precedence.Change
Record pattern registrations in an indexed array and use that order when selecting the last matching filter. Keep the existing pattern-to-function mapping. Add a save-path regression covering broad/specific patterns in both orders and re-registration of an existing pattern.
Validation
96ab414343b9467fca5ef46f04bc1bd1fc7bd8f1, emitting two unexpectedCopyFilelines; passes with the fix.make lintpasses, including the pinned ShellCheck 0.11.0 and style checks.diffpass with synthetic files.