Repository navigation
Fix client crash when a pressing item stack becomes empty - #10885
Open
CIR-Server wants to merge 1 commit into
Open
CIR-Server wants to merge 1 commit into
CIR-Server wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Fixes #10886
While a pressing contraption runs, an item stack kept in
particleItemscan beemptied by the processing. Such empty stacks are still written into the client
packet (
count: 0), deserialize back intoItemStack.EMPTY, and are thenhanded to
ItemParticleOption, which throwsIllegalArgumentException: Empty stacks are not allowedand disconnects the client.Fix
Drop empty stacks from
particleItemsbefore the client packet is written, andagain before particles are spawned.