Skip to content

build(deps): Bump docker/login-action from 4.7.0 to 4.8.0 - #1196

Merged
hoffmang9 merged 1 commit into
mainfrom
dependabot/github_actions/docker/login-action-4.8.0
Nov 14, 2026
Merged

hoffmang9 merged 1 commit into
mainfrom
dependabot/github_actions/docker/login-action-4.8.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Bumps docker/login-action from 4.7.0 to 4.8.0.

Release notes

Sourced from docker/login-action's releases.

v4.8.0

Full Changelog: docker/login-action@v4.7.0...v4.8.0

Commits
  • 8aa5831 Merge pull request #1105 from docker/dependabot/npm_and_yarn/docker/actions-t...
  • 043f81d [dependabot skip] chore: update generated content
  • 3ff6998 build(deps): bump @​docker/actions-toolkit from 0.107.0 to 0.109.0
  • 694ef6a Merge pull request #1103 from docker/dependabot/npm_and_yarn/aws-sdk-dependen...
  • 7c6e412 [dependabot skip] chore: update generated content
  • aa2441f build(deps): bump the aws-sdk-dependencies group across 1 directory with 2 up...
  • d6c10b0 Merge pull request #1106 from docker/dependabot/github_actions/codeql-actions...
  • 319f1ee Merge pull request #1104 from docker/dependabot/github_actions/actions/setup-...
  • b483b7f Merge pull request #1101 from docker/dependabot/npm_and_yarn/vite-7.3.7
  • dc7d67c Merge pull request #1070 from crazy-max/increase-oidc-default-expiry
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note

Low Risk
Single GitHub Actions dependency pin in CI with unchanged login configuration.

Overview
Bumps the Login to GitHub Container Registry step in the deploy review workflow from docker/login-action@v4.7.0 to v4.8.0. No workflow inputs or registry credentials change—only the action version used when packaging and pushing review-app images to ghcr.io.

Reviewed by Cursor Bugbot for commit 4b1898b. Bugbot is set up for automated code reviews on this repo. Configure here.

Bumps [docker/login-action](https://github.com/docker/login-action) from 4.7.0 to 4.8.0.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@v4.7.0...v4.8.0)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-version: 4.8.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Nov 14, 2026
@github-actions

Copy link
Copy Markdown

Dependency Artifact Review

Result: success
Reason: the agent verdict is clean

Agent reason: Minor release that bumps dependencies and raises the default Docker Hub OIDC token lifetime to 3600s; the bundle changes match the upstream library updates and contain nothing suspicious.

Updates

  • docker/login-action v4.7.0 -> v4.8.0: reviewed

Facts

  • docker/login-action: reviewed artifacts: old commit 81c6f93d4bc991e510b342a00b419b3bb4efc5c6, new commit 8aa5831fb8d48d8f76594c7ddde61ae58019f550
  • docker/login-action: tag v4.7.0 resolved to 81c6f93d4bc991e510b342a00b419b3bb4efc5c6, v4.8.0 to 8aa5831fb8d48d8f76594c7ddde61ae58019f550
  • manifest or build file changed: package.json
  • diff size: 20913316 bytes in 9 files; changes.diff has 20887611 bytes
  • largest change: 00-docker_login-action/dist/index.cjs.map (16452694 bytes)
  • largest change: 00-docker_login-action/dist/index.cjs (4429050 bytes)
  • largest change: 00-docker_login-action/dist/licenses.txt (3463 bytes)
  • largest change: 00-docker_login-action/README.md (1082 bytes)
  • largest change: 00-docker_login-action/package.json (751 bytes)
  • largest change: 00-docker_login-action/src/dockerhub.ts (571 bytes)
  • not in changes.diff: 3 files, 25705 bytes (1 .github, 1 lockfile, 1 test or fixture); all are in excluded.diff
  • excluded from changes.diff, see excluded.diff: 00-docker_login-action/.github/workflows/codeql.yml (.github, 1277 bytes)
  • excluded from changes.diff, see excluded.diff: 00-docker_login-action/tests/dockerhub.test.ts (test or fixture, 1725 bytes)
  • excluded from changes.diff, see excluded.diff: 00-docker_login-action/yarn.lock (lockfile, 22703 bytes)

Dependencies added transitively and not listed as updates are not artifact-reviewed.

Agent review

I'll start by reading the metadata and diff.The source change is tiny. Next I'll check the bundled dist/index.cjs diff for suspicious additions.The bundle is minified (about 254 lines) and grew by roughly 115 KB. I'll use the source maps to diff it module by module.## Malware findings

I found nothing suspicious in this update.

  • Hand-written source: The only change is in src/dockerhub.ts line 16. The default Docker Hub OIDC token lifetime goes from 300 to 3600 seconds. The 300–21600 bounds are unchanged, and the README and test changes match it.
  • package.json: Only version bumps: @aws-sdk/client-ecr and @aws-sdk/client-ecr-public to ^3.1161.0, and @docker/actions-toolkit to ^0.109.0. No install scripts were added.
  • Bundled dist/index.cjs (minified, about 115 KB larger): I compared it module by module using the source map's embedded sources. There are 61 changed modules, all AWS SDK, Smithy, semver and src/dockerhub.ts updates. None of the added lines contain process spawning, eval, dynamic code, base64 decoding of payloads, new URLs or new token reads.
  • New modules in the bundle: 153 were added. 151 are a nested copy of @smithy/core under @smithy/credential-provider-imds, and all 151 are byte-identical to the old top-level @smithy/core. The other two are normal library files, a semver helper and the Smithy RPC v2 JSON protocol code.
  • Bundle-wide checks: The set of URLs in the bundle is unchanged. The counts of child_process, eval, atob, writeFileSync, ACTIONS_ID_TOKEN and ACTIONS_RUNTIME_TOKEN are unchanged. The only new uppercase string constants are ECR status values (PREPARING, STOPPED, STOPPING). The extra process.env reads come from the duplicated AWS metadata-service code.
  • Excluded files: These are a CodeQL workflow with SHA-pinned action bumps, the matching test update and yarn.lock version bumps. None of them are suspicious.

Compatibility

This is based on the published artifacts for v4.7.0 and v4.8.0 only.

  • Same setup: The runtime is still node24 with dist/index.cjs as both the main and post step. action.yml did not change, so inputs and outputs are the same.
  • One behaviour change: For Docker Hub OIDC login, if DOCKERHUB_OIDC_EXPIREIN is not set, the Docker Hub token now lasts 1 hour instead of 5 minutes. Workflows that want the old short lifetime can set DOCKERHUB_OIDC_EXPIREIN: 300.
  • Everything else: These are minor or patch dependency updates (AWS SDK ECR clients, Smithy, @docker/actions-toolkit 0.107 to 0.109). No APIs were removed and no new configuration is required.

MALWARE: clean
MERGE: yes
REASON: Minor release that bumps dependencies and raises the default Docker Hub OIDC token lifetime to 3600s; the bundle changes match the upstream library updates and contain nothing suspicious.

Verdict: Malware: clean | Merge: yes

@hoffmang9
hoffmang9 merged commit 7045afb into main Nov 14, 2026
11 of 12 checks passed
@hoffmang9
hoffmang9 deleted the dependabot/github_actions/docker/login-action-4.8.0 branch November 14, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant