Repository navigation
Fix mypy errors from typed pytimeparse - #256
Merged
Merged
Conversation
ibutterbot
approved these changes
Oct 27, 2026
ibutterbot
left a comment
Contributor
There was a problem hiding this comment.
Code changes look correct: drops the stale type: ignore, handles parse()→None with a clear ValueError, and the new test covers invalid input. Clean and minimal.
The macOS 3.11 Intel CI failure is a transient runner network issue (couldn't resolve index.crates.io while building cryptography from source) — unrelated to this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytimeparse now ships type hints, so the pre-commit mypy hook fails on every PR (unused
type: ignoreandNone / floatinNetwork.skip_time). Remove the stale ignore, raiseValueErrorfor unparseable durations, and add a test.Note
Low Risk
Test-harness-only typing and input validation; no production or security paths affected.
Overview
Fixes mypy failures after
pytimeparsegained type stubs: drops the obsolete# type: ignoreon the import and handlesparse()returningNoneinNetwork.skip_timeby raisingValueErrorinstead of passingNoneinto arithmetic.Adds
test_skip_time_invalid_durationto assert invalid duration strings fail withValueError.Reviewed by Cursor Bugbot for commit 2dac479. Bugbot is set up for automated code reviews on this repo. Configure here.