Repository navigation
Conversation
Since Catrobat#5041 "color at x y" returns upper-case hex (#FFFFFF), but four catrobatTests projects still expect #ffffff and fail. Two test projects load looks from catrob.at, which Catrobat no longer owns; they now load two media library images from share.catrobat.org. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five projects in
catroid/src/androidTest/assets/catrobatTestsare out of date:bricks/looks/testChangeSize,bricks/looks/testDeleteWebLook,colorAtXY/testColorAtXYOutsideStageandcolorAtXY/testColorAtXYWithoutLooksexpect#fffffffrom "color at x y". Since CATROID-1613 Fix ColorDetection ignoring z-index #5041 the sensor returns upper case (#FFFFFF), so they fail. They now expect#FFFFFF.formula/testNumberOfLooksandbricks/looks/testDeleteWebLookload looks fromhttps://catrob.at/penguinand/racoon. Catrobat no longer owns that domain. They now load two images from share's media library (https://share.catrobat.org/resources/media/<id>.png, public,catrobat.orgis already a trusted domain).Only the
code.xml(andundo_code.xml) inside the archives changed; the other entries are copied unchanged.Found by running all catrobatTests projects in the browser player on share (Catrobat/Catroweb,
player/), which plays them with Catroid's engine.🤖 Generated with Claude Code