Repository navigation
fix: keep bad targets, degenerate links and cron steps from aborting the poller - #353
Open
somethingwithproof wants to merge 1 commit into
Open
somethingwithproof wants to merge 1 commit into
somethingwithproof wants to merge 1 commit into
Conversation
…the poller An unrecognised TARGET, a zero-width or doubled-back link, the first sample of a new weathermap_data row and a */0 schedule each threw out of the poller. Cron fields now also accept lists and ranges. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unrecognised target now counts as no data, the link geometry returns the shared vertex or a zero normal instead of dividing by zero, a new
weathermap_datarow's first sample gives a zero rate, and schedule fields accept*,N,N-M, lists and/step, with a zero step never matching. The poller hook also catches a failed map run, logs it and releases its lock, and returns instead of callingexit(1)when another run holds the lock.Tested on PHP 8.5 in Docker. The new
tests/Unit/PollerCrashGuardTest.phpreproduces each failure and fails without the fix, the full Pest suite passes apart from the twoDocumentationExampleHoverTestfailures that also fail on develop, and patch coverage is 100%. The CHANGELOG entry is in #352's branch to keep the two PRs from conflicting.Fixes #351