[bmfmancini]

The v4 device backfill compared JSON_TYPE() output (server default utf8mb3_uca1400_ai_ci on MariaDB 11.x) with a literal in Cacti's connection collation (utf8mb3_general_ci), failing with error 1267 and leaving the plugin at "Awaiting Configuration". Compare the bytes with CAST(... AS BINARY) instead.

Schema steps also failed silently; every failure path now logs the step, reason and database error to the Cacti log.

Fixes #15

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[somethingwithproof]

Blocker: the new failure-reporting paths in includes/schema.php fail the existing changed-line coverage gate in all five CI jobs: 11/33 executable lines covered (33.33%). SetupTest covers the v4 write failure and a direct helper call, but leaves the other changed migration failure branches unexercised. Extend the existing tests to drive those database-read/write failures and verify that each migration returns false, logs the correct step, and does not advance its version; alternatively, keep this PR focused on the collation fix. The existing 100% patch gate must pass before approval. The CI unit tests themselves pass; the failure is the subsequent coverage gate.

[bmfmancini]

Thanks @somethingwithproof. I extended the existing tests rather than narrowing the PR (9d6378d).

SetupTest now has a data set for every failure branch this PR adds to includes/schema.php, covering v1 to v14: the unsupported database version checks, storage reads, failed writes and the InnoDB checks. Each case checks that the step returns false, logs exactly one schema step vN failed (reason) line (with the database error only for storage failures), and does not write a schema version. A companion case runs a full install against the same fake database and checks that it logs nothing and reaches v14, so each failure comes from its own fault rather than from the fake.

Locally, under Pest with pcov, tests/bin/patch-coverage.php reports 32/32 changed lines covered (it was 11/33). The 31 new cases pass, and php-cs-fixer is clean on the changed test.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Resolved by Sean.