Repository navigation
Publish current PDF, text, and contributed manual replacements - #254
Open
somethingwithproof wants to merge 13 commits into
Open
somethingwithproof wants to merge 13 commits into
somethingwithproof wants to merge 13 commits into
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…itions Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…irectly Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
This was referenced Nov 8, 2026
…ments Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The published PDF/text manuals and contributed installation guides describe historical Cacti versions. This adds current replacements while preserving the original archive URLs, contributor credits, and rights notices.
Validation: 6 edition-helper tests, 19 HTML-renderer tests, and 2 navigation regression tests pass, with 100% line and branch coverage for those two helpers. Real publication checks validate all 9 PDF/text editions, source/output hashes, complete selected chapters, internal PDF links, and non-English cover text. Browser E2E tests render 217 HTML pages and preserve all 75 legacy routes and 313 bookmarks. At
55aa975the local main PDF contained 136 chapters across 516 pages; pagination can vary with native fonts/libraries. Markdown, spelling, and workflow checks pass.Builds on #253, which carries the updated chapters and HTML publication workflow, and merges #250's branch, whose PDF and navigation tooling (
bin/build_pdf_docs.py,bin/check_navigation.py, the tool lock andresources/css/pdf.css) it extends in place with language and title parameters,--companionsand a heading parser. Merge #250 before this PR; once #250 is on develop, those files show only this PR's changes. #250's query examples and ReportIt work are reviewed in #250. CI uploads current manuals, manifests, coverage, and previews for 14 days. Publishing to the public file host remains a maintainer deployment step; archive files should keep their existing names and notices.Native stack registration attempted with
gh stack link --base develop 248 252 253 254. GitHub rejected it because #248 has auto-merge enabled. That setting is preserved. The PR base chain is #248 → #253 → #254 (#252 has merged into #248's branch); body links are not a substitute for native stack registration.The editions are rebuilt once from this PR's sources in a CI-matching ubuntu:24.04 container, and their manifests name that source commit.
bin/tests/verify_other_manuals.pyreports the set complete, with 127 schema tables and 11 archived originals. check_navigation reports no errors, and the edition, navigation and HTML-renderer tests and codespell pass on the final tree. Hosted checks must run again on the current head.Sonar duplication analysis excludes only the pinned upstream schema SQL and its deliberately generated DDL reference. Authored code remains in duplication analysis and the project thresholds are unchanged. Navigation heading parsing also avoids the previously flagged ambiguous regex.
Hosted validation passed at the earlier head
55aa975: complete HTML/browser publication, PDF/text edition publication, and both Sonar checks. The browser suite also verifies the language declarations of all four localized HTML guides.Downloaded artifacts were checked after upload: ZIP integrity and SHA-256, every manual output checksum, both 100% helper coverage reports, all 5 browser cases, and the populated PDF preview. The hosted Linux main PDF has 529 pages; its 136 chapters match the local build despite font-dependent pagination.