Repository navigation
Release 1.2.1 - #157
Merged
Merged
Release 1.2.1#157
Conversation
Co-authored-by: FlorianRappl <1766191+FlorianRappl@users.noreply.github.com>
…tions-job-again Run promise settlements with engine context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
This pull request introduces bug fixes and new features related to JavaScript script execution and function source text handling in AngleSharp.Js. The key improvements are ensuring scripts inserted via DOM methods execute immediately (matching browser behavior), and allowing the retention or omission of original function source text, which affects
Function.prototype.toString()and caching. The update also includes comprehensive tests and documentation for these behaviors.These changes improve compatibility with browser script behaviors (e.g., as relied on by MediaWiki), enhance configurability, and ensure more predictable script execution and caching.