Skip to content

Read the diff:match result without the IHtmlCollection indexer #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelthyregod wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Read the diff:match result without the IHtmlCollection indexer #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab42a38
Read the diff:match result without the IHtmlCollection indexer
michaelthyregod Nov 8, 2026
387c5e6
Run the tests on AngleSharp 1.10.0
michaelthyregod Nov 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/AngleSharp.Diffing.Tests/AngleSharp.DiffingTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
</PropertyGroup>

<ItemGroup>
<!-- Run the tests on a newer AngleSharp than the library's minimum: from 1.3.1 its .NET 8 build
differs from the netstandard2.0 build the library compiles against (IHtmlCollection<T> indexer). -->
<PackageReference Update="AngleSharp" Version="1.10.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<PackageReference Include="GitHubActionsTestLogger" Version="2.4.1">
<PrivateAssets>all</PrivateAssets>
Expand Down
2 changes: 1 addition & 1 deletion src/AngleSharp.Diffing/Strategies/ElementStrategies/CssSelectorElementMatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ private static bool TryGetTestNode(IDiffContext context, string cssSelector, [No
testNode = searchResult.Length switch
{
0 => null,
1 => searchResult[0],
1 => searchResult.First(),
_ => throw new DiffMatchSelectorReturnedTooManyResultsException($@"The CSS selector ""{cssSelector}"" returned {searchResult.Length} matches from the test node tree. No more than one is allowed.")
};

Expand Down