Repository navigation
fix: SG-45792: Keep annotation color picker on screen when docked right - #1474
Merged
cedrik-fuoco-adsk merged 4 commits intoNov 4, 2026
Conversation
The annotate_beta color picker popup always opened to the right of the color swatch, so with the toolbar docked on the right of a fullscreen RV window it opened partly off screen. Open it to the right by default, flip it to the left when it would overflow the screen, and clamp it to the screen's available geometry both horizontally and vertically. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
marked this pull request as ready for review
October 29, 2026 17:16
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
October 29, 2026 17:16
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
eloisebrosseau
approved these changes
Nov 4, 2026
cedrik-fuoco-adsk
merged commit Nov 4, 2026
9d697c5
into
AcademySoftwareFoundation:main
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
N/A (internal ticket SG-45792)
Summarize your change.
The
annotate_betacolor picker popup now opens on whichever side of the color swatch has room, and always stays inside the screen.Describe the reason for the change.
The popup was always placed to the right of the color swatch. With the annotation toolbar docked on the right of a fullscreen RV window, that put most of the popup off screen, so only part of the color palette could be used.
The popup is a frameless
Qt.Toolwindow, not aQt.Popup, so Qt doesn't keep it on screen. It can't simply become aQt.Popupeither: that would close it on outside clicks, which breaks dragging the HSV gradient while drawing.Describe what you have tested and on which operating system.
To be filled in.
Add a list of changes, and note any that might need special attention during the review.
annotate_beta_color_picker.py:ColorPickerPopup.show_near()places the popup to the right of the swatch, flips it to the left if it would go past the right edge of the screen, then clamps it to the screen's available geometry (horizontally and vertically, since the popup can sit low in the toolbar). It uses the swatch's own screen, so it handles floating docks and multiple monitors without knowing the dock area._POPUP_ANCHOR_SPACING. The value is unchanged; the original commit didn't explain it, so the comment records my reading of the layout.