Skip to content

build: 兼容低于 mingw-w64 10 版本运行时的编译器 - #402

Merged
yixy-only merged 1 commit into
x-ege:masterfrom
yixy-only:build_mingw_compact
Oct 25, 2026
Merged

build: 兼容低于 mingw-w64 10 版本运行时的编译器#402
yixy-only merged 1 commit into
x-ege:masterfrom
yixy-only:build_mingw_compact

Conversation

@yixy-only

@yixy-only yixy-only commented Oct 25, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

RedPanda C++ 提供的 gcc 11.5.0 使用的 mingw-w64 运行时低于 10，提供的 mfidl.h 头文件缺失 ccap 所使用函数声明
改动：针对 mingw-w64 低版本运行时补充缺失的函数声明

Summary by CodeRabbit

  • Bug Fixes
    • 修复在部分 MinGW 工具链构建的 Windows 版本中，相机采集可能无法正常编译的问题。
    • 此修复仅影响使用 MinGW 的 Windows 相机采集构建，不影响其他 Windows 工具链或源文件。

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 89a9d8c5-6236-45b1-ac60-4ce878cf37f4
Commits

Reviewing files that changed from the base of the PR and between 09387a8 and 93bd9c6.

Files selected for processing: 2
  • CMakeLists.txt
  • src/compiler_compat/mingw-w64/mfidl_compat.h

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

新增旧版 MinGW-w64 的 Media Foundation 兼容声明。启用 Windows 相机采集时，CMake 仅为 ccap_imp_windows_msmf.cpp 强制包含兼容头文件。

Changes

相机采集兼容性

层 / 文件 摘要
MinGW 兼容声明与编译接入
src/compiler_compat/mingw-w64/mfidl_compat.h, CMakeLists.txt		 兼容头文件在符合条件的旧版 MinGW-w64 配置下声明 MFCreateDeviceSource。Windows 相机采集分支为指定源文件强制包含该头文件。

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: wysaid

Merge Risk: Minimal · up to 93bd9

No actionable merge-blocking risk was identified in the compatibility change.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed 标题准确概括了本次变更的主要目的：为低于 mingw-w64 10 版本的环境补充兼容支持。标题简洁且与代码改动直接相关。
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

小兔翻开编译书，
找到旧版兼容符。
相机源文件添新声明，
MinGW 编译路更清楚。
兔耳轻摇，收好工具。

Comment @coderabbitai help to get the list of available commands.

@yixy-only
yixy-only merged commit a590854 into x-ege:master Oct 25, 2026
20 checks passed
@yixy-only
yixy-only deleted the build_mingw_compact branch October 25, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yixy-only