Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
External dependency paths prevent clean builds, and default source locations produce incorrect debug mappings.
2 open issues
What changed in this PR
Updates Wasmer’s Cranelift integration for newer upstream APIs, including the unwind accessor requested in wasmtime#14882.
Changes:
- Switches Cranelift dependencies to a local Wasmtime checkout.
- Adapts exception metadata, relocations, unwind access, and source locations.
| File | Description |
|---|---|
| lib/compiler-cranelift/src/eh.rs | Adapts exception-handler metadata APIs. |
| lib/compiler-cranelift/src/compiler.rs | Updates relocation types and unwind access. |
| lib/compiler-cranelift/src/address_map.rs | Converts the new source-location representation. |
| Cargo.toml | Replaces registry dependencies with local paths. |
| Cargo.lock | Records Cranelift and Wasmtime development dependencies. |
Review effort: Balanced
syrusakbary
approved these changes
Oct 28, 2026
marxin
force-pushed
the
bump-cranelift-0.137
branch
from
November 3, 2026 15:33
64e36ef to
3600180
Compare
marxin
force-pushed
the
bump-cranelift-0.137
branch
from
November 6, 2026 12:53
efc252e to
9fe1e53
Compare
marxin
force-pushed
the
bump-cranelift-0.137
branch
from
November 6, 2026 13:07
f500ef7 to
13d8017
Compare
Collaborator
Author
|
Will be done in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Depends on: bytecodealliance/wasmtime#14882Will be fixed in the next Wasmtime release (51).