From 4956428229e70296ed5933dcca4c40613eaf52bd Mon Sep 17 00:00:00 2001 From: mhucka Date: Tue, 27 Oct 2026 21:32:32 +0000 Subject: [PATCH] Fix #1129: typo in parameter name MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In `tensorflow_quantum/core/serialize/serializer_test.py`, `test_serialize_circuit_wrong_type` and `test_deserialize_circuit_wrong_type` were passing `input` instead of the actual parameterized test argument, `inp`. Because `input` exists:(it's a Python built-in), but is neither a `cirq.Circuit` nor a `tfq.proto.Program`, `TypeError` was raised by accident, masking that the parameterized values (`'wrong'`, `1.0`, `None`, `[]`) were never passed into the serializer functions. Fix: `input` → `inp`. --- tensorflow_quantum/core/serialize/serializer_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tensorflow_quantum/core/serialize/serializer_test.py b/tensorflow_quantum/core/serialize/serializer_test.py index 3a89a03ea..b23ed81cc 100644 --- a/tensorflow_quantum/core/serialize/serializer_test.py +++ b/tensorflow_quantum/core/serialize/serializer_test.py @@ -724,13 +724,13 @@ def test_serialize_noise_channel_unsupported_value(self): def test_serialize_circuit_wrong_type(self, inp): """Attempt to serialize invalid objects types.""" with self.assertRaises(TypeError): - serializer.serialize_circuit(input) + serializer.serialize_circuit(inp) @parameterized.parameters([{'inp': v} for v in ['wrong', 1.0, None, []]]) def test_deserialize_circuit_wrong_type(self, inp): """Attempt to deserialize invalid objects types.""" with self.assertRaises(TypeError): - serializer.deserialize_circuit(input) + serializer.deserialize_circuit(inp) @parameterized.parameters([{'inp': v} for v in ['wrong', 1.0, None, []]]) def test_serialize_paulisum_wrong_type(self, inp):