Repository navigation
Conversation
BioC 3.23 BUILD failed on both Linux builders. The quick-start vignette
runs live GEO code, and each builder hit a different NCBI hiccup:
- nebbiolo1: searchGEO() -> rentrez efetch got "HTTP failure: 400"
wrapping an NCBI "WWW Error 500" page (GEOquery.qmd:111-121).
- kunpeng2: getGEO("GSE2553") hit "OpenSSL SSL_read: SSL_ERROR_SYSCALL"
from ftp.ncbi.nlm.nih.gov (GEOquery.qmd:75-79).
This backports the precompiled-vignette pattern from devel (2.81.28). The
live source moves to vignettes/GEOquery.qmd.orig, and the shipped
vignettes/GEOquery.qmd is generated by dev/precompute-vignettes.R, which
runs the release code via pkgload::load_all, with the real output baked
in. .Rbuildignore drops dev/, the .qmd.orig source, and any stray
download dirs. single-cell.qmd already sets execute: eval: false, so it
stays as it is.
Verified: with network blocked through a dead proxy, R CMD build of
upstream/RELEASE_3_23 fails at GEOquery.qmd:75-79, and this branch
builds cleanly.
Version bump to 2.80.1.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When BUILD fails, the builders skip CHECK, so these were hidden. Once
the vignette fix lets BUILD pass, CHECK would run four examples that call
NCBI live: searchFieldsGEO(), hasRNASeqQuantifications(),
getRNASeqQuantGenomeInfo(), and getRNASeqData(). Run locally,
getRNASeqData("GSE164073") fails with "invalid 'row.names' length",
because the GEO download service now answers the shared
Human.GRCh38.p13.annot.tsv.gz request with a reCAPTCHA HTML page instead
of the file. Devel already keeps these examples in \dontrun{} or
\donttest{}.
Rd edited by hand to match roxygen output (release pins RoxygenNote
7.3.2; regenerating with 8.x would rewrite every page).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
@claude resolve the merge conflicts in this pull request |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Bioconductor 3.23 release BUILD failure, where the quick-start vignette died on transient NCBI errors. It also keeps the CHECK step that follows off live NCBI.
About the base branch
GitHub had no branch mirroring Bioconductor's
RELEASE_3_23, so I createdRELEASE_3_23here atupstream/RELEASE_3_23(8b846af, git.bioconductor.org). That keeps the diff to these 2 commits.develwould be the wrong base, because this branch descends from the release, andmainis a stale 2025 branch. Nothing has been pushed to git.bioconductor.org. Releasing to Bioconductor is a separate step.CI caveat:
R-CMD-check.yamlonly runs on PRs intomainanddevel, so this PR gets pkgdown and no R CMD check. I tried to runR CMD build/checklocally with the network blocked, but the agent's sandbox blocked that run, so there is no local check evidence from this session either. The commit message for1731f52records an earlier local run: with the network blocked through a dead proxy,R CMD buildofupstream/RELEASE_3_23fails atGEOquery.qmd:75-79, and this branch builds cleanly. Please re-runR CMD buildandR CMD checkbefore pushing to Bioconductor.What broke, and since when
searchGEO()→ rentrez efetch gotHTTP failure: 400, wrapping an NCBI "WWW Error 500" page (GEOquery.qmd:111-121).getGEO("GSE2553")hitOpenSSL SSL_read: SSL_ERROR_SYSCALLfrom ftp.ncbi.nlm.nih.gov (GEOquery.qmd:75-79).getRNASeqData("GSE164073"), fails today withinvalid 'row.names' length, because NCBI serves a reCAPTCHA page for the shared annotation file (NCBI reCAPTCHA still blocks the mouse RNA-seq annotation file (Mouse.GRCm39.annot.tsv.gz) #230). On devel, the same NCBI behaviour has kept the scheduled integration workflow red since 2026-08-31.What the fix does
1731f52precompilesGEOquery.qmd, backporting the pattern devel uses since 2.81.28:vignettes/GEOquery.qmd.orig. The shippedvignettes/GEOquery.qmdis generated bydev/precompute-vignettes.R, which bakes in real output, soR CMD buildruns no NCBI code..Rbuildignoreexcludesdev/, the.qmd.origsource and stray download dirs.single-cell.qmdalready haseval: falseand is unchanged.51bde97moves thesearchFieldsGEO(),hasRNASeqQuantifications(),getRNASeqQuantGenomeInfo()andgetRNASeqData()examples into\donttest{}. Devel already does this. The Rd files were edited by hand to match roxygen output, because the release branch pins RoxygenNote 7.3.2 and regenerating with 8.x would rewrite every page.Checklist
# GEOquery 2.80.1entryVersion:2.80.1;Date:not bumped (still 2025-09-03)Notes for reviewers
NEWS.mdalready had a# GEOquery 2.99.1 (unreleased)heading before this PR. The new 2.80.1 entry goes above it, and the old heading is left as it was.RELEASE_3_23deployed release docs to gh-pages, because pkgdown deploys on every push. Devel docs are being redeployed straight after. The workflow problem is tracked in a separate issue.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kiag4wGqrFcF739dXWtPZi