Repository navigation
Update to vkutil v0.30.0 - #23
Merged
Merged
Conversation
|
Reviewed: this is a dependency-only bump (
Possible follow-up, not a blocker: there's no test that the pool times out against an unresponsive server. The fix depends entirely on upstream defaults, so a later vkutil change could quietly undo it. A short test with a listener that accepts connections and never replies would pin the behaviour down. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates vkutil from v0.26.0 to v0.30.0, so the Valkey pool gets default connect, read and write timeouts. Previously a half-open connection could block a request indefinitely.
Changes
go.mod/go.sum: bumpgithub.com/nyaruka/vkutilto v0.30.0. No code changes were needed:RateLimiter(changed in v0.29.0) isn't usedvkutil.NewPool(cfg.Valkey, vkutil.WithMaxActive(16))and now picks up the default timeouts. Helpsites only issuesPING,GETandSET, with no blocking commands or scripts, so the default read timeout needs no override.Test plan
go build ./...andgo vet ./...go test ./...in the devcontainer